Access private GitHub repos using GitHub app credentials #5
+1,068
−874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the gitsha is needed to update status, it never made much sense to have a separate option for this. Also, commit status updates are now turned on if you pass --github-context.
bittrance
force-pushed
the
github-app-repo-access
branch
from
50f3fb8 to
f56e23c
Compare
This is a bit hackish, it may be that we should start looking at doing proper checkouts.
bittrance
force-pushed
the
github-app-repo-access
branch
from
f56e23c to
d9cee1e
Compare
bittrance
force-pushed
the
github-app-repo-access
branch
from
cce01a3 to
62addf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes kitops automatically use configured github app credentials when cloning/fetching repositories. It also removes the
--github-repo-slugoption and instead calculates the repo to update commit statuses i from the repository URL. Also, commit status updates are now controlled by--github-context.